activerecord-sqlserver-adapter icon indicating copy to clipboard operation
activerecord-sqlserver-adapter copied to clipboard
verified publisher icon rails-sqlserver

fix-change-column-default

Open nemesit opened this issue 3 years ago • 1 comments

Would fix #1018

nemesit avatar Jul 20 '22 11:07 nemesit

@nemesit Would you be able to add tests to the PR? The default constraint should be dropped when nil is passed rather than not altered. Could you confirm in your tests that this happens?

aidanharan avatar Jul 25 '22 09:07 aidanharan

Closing as I don't believe this is a bug. The approach taken by the MSSQL adapter is the same used by the MySQL adapter. The Rails change_column_default tests currently pass for the MSSQL adapter.

aidanharan avatar Dec 20 '22 16:12 aidanharan