summer-of-code
summer-of-code copied to clipboard
rails-girls-summer-of-code
Blog category updates
@alicetragedy I took a look at those other two issues and found a fix for both.
For the first, I assumed you meant someplace in the sidebar, so I moved the category listings there. They still link to the categoryview anchor tags, but will allow users to quickly navigate to posts just in a category.
For the comma issue... yeah I agree that is a weird one. I'm not sure where that space is coming from. After investigating, it looks like it is actually helping us for the 'and' one, so I didn't want to nuke it (even if I could). I ended up adding a css hack (margin-left:-2px) for the comma which seems to have corrected the issue at least visually.
Hope these are helpful!
Chris
I've made some screenshots (see below) of what I meant originally when I said that you couldn't see the categories on the blog index. Basically, when you go on /blog, you see the last few posts, and the information under the title only shows post date and author. The categories of each blog post are only visible in the “single blog post view” (basically, when you click on the post to view it by itself). I'm not sure if this is a big deal or not, what do you think? It was something that confused me originally but I'd love to have your thoughts on this.
view from the blog index
view from the single blog post
Hej @iamchrissmith, would you be able to and have time to pick up this PR again? There's a few changes I requested which I can help with, and I'd love to see this merged soon!
@alicetragedy I have been meaning to get back to this, but have been diverted by holidays and a new job. I have travel and a move over the next month or so. I would still be happy to get back to this, but it might be a couple of months. Sorry for the delay!
no worries, @iamchrissmith! Totally understandable. I'll put this on the back burner for now and ping you about it again in a few weeks. In the event that we need this merged earlier, would it be ok for you if we cherry-picked your commits (so your contributions would still show) and built on top of what you already have? I'll see how to proceed, but I wanted to ask you just in case!
Of course, please cherry pick away, don't let me become a blocker :-)
@iamchrissmith sorry for following up so late :) Is this something you'd be able to and be interested in improving? I'm not sure what your time commitment looks like over the next weeks and if you are able to look into this :)