Correct student names in confirmation email

[cesswairimu]

Restore email sending code So as to investigate the bug and find solution

Related issue #955

[cesswairimu]

@ramonh could you kindly look at this, it is working fine from my end, Thanks

[hola-soy-milk]

Hi @cesswairimu

My apologies! I wasn't sure if you needed a review 😅

I'll have a look! Thank you!

[emcoding]

Hey @cesswairimu, this is getting real close! Are you still interested in finishing it? Let us know if we can help, or if we can close this?

[cesswairimu]

Sorry @F3PiX Yes I am interested in finishing. I could use some help in testing. I tried implementing some tests but they are making another block of specs to fail. Should I push the file? or attach the snippet here so you can take a look? Thanks

[pgaspar]

Hey @cesswairimu 👋 I think you can do whatever you prefer. We'll try to help either way 👍

[cesswairimu]

Thanks @pgaspar just pushed the code. Thanks.

[cesswairimu]

@ramonh @pgaspar Please take a look and tell me if that covers the review changes requested. Thanks

[cesswairimu]

Gotcha @ramonh will take a look see what I can find

[emcoding]

Heads up: Changes in #1007 has effect on this PR. See bc26170 (and its commits message).

@cesswairimu To make sure that your changes still work, you can pull the remote master branch into your local master branch, and then rebase. Or, if you don't want to rebase, go to your local master, pull the remote master; and open a new PR/branch.

[cesswairimu]

:+1: Thanks @F3PiX