rgsoc-teams icon indicating copy to clipboard operation
rgsoc-teams copied to clipboard

Ensure correct student names are in the application confirmation emails

Open hola-soy-milk opened this issue 7 years ago • 9 comments

As quickly gone over in PR #951, we've had to temporarily disable application confirmation emails as we had an incident where students were sent the opposite applications with the opposite names.

We need to have a way to ensure that the correct student_index is used for student0 and student1.

hola-soy-milk avatar Feb 28 '18 07:02 hola-soy-milk

Hi @ramonh I would love to work on this issue

cesswairimu avatar Mar 05 '18 10:03 cesswairimu

Hey @cesswairimu, sure thing, thank you so much for offering to help!

Please make sure to let me know if I can help you in any way.

hola-soy-milk avatar Mar 05 '18 12:03 hola-soy-milk

@ramonh after rebasing I am getting this error. Tried to find some work around but nothing seems to work. screenshot from 2018-03-13 11-32-39

cesswairimu avatar Mar 13 '18 08:03 cesswairimu

Hey @cesswairimu Thanks for bringing this up!

I tried checking out your branch and oddly enough, it seems to be working on my end. However, I'm on macOS so I suspect it could be a gem installation issue.

Did I understand correctly that it worked before?

Maybe one thing you could try is reinstalling the gems in your bundle. You can do that by running the following:

$ bundle install --force

Hope this helps!

hola-soy-milk avatar Mar 14 '18 09:03 hola-soy-milk

yes, It worked before. I forked the repo a while back and after pulling the lastest changes, I am getting the error. Could be something to do with the upgrade to ruby-2.5.0 I am guessing. I just tried to fork the clone the repo directly and i am getting the same error.

cesswairimu avatar Mar 14 '18 11:03 cesswairimu

Very odd, and I take it re-installing the gems didn't work?

hola-soy-milk avatar Mar 14 '18 11:03 hola-soy-milk

Yep reinstalled successfully but the error persists

cesswairimu avatar Mar 14 '18 11:03 cesswairimu

Aw!

Let's try a theory. Could you try opening the .ruby-version and changing it back to, what I believe was 2.3.1?

Then you can cd out and back in to try?

hola-soy-milk avatar Mar 14 '18 11:03 hola-soy-milk

:+1: That works Thanks a lot

cesswairimu avatar Mar 14 '18 13:03 cesswairimu