rgsoc-teams icon indicating copy to clipboard operation
rgsoc-teams copied to clipboard

Testing: Verify partial doubles

Open carpodaster opened this issue 7 years ago • 5 comments

Working on #905 revealed that we stub methods on objects that originally do not respond to these methods – and that's a trap! We can set verify_partial_doubles to true in spec/spec_helper.rb but that will break tests. These tests will have to be fixed.

Why is this important? See this example in the RSpec docs.

carpodaster avatar Jan 05 '18 21:01 carpodaster

Hi there! I’m a first-time contributor and was hoping to help out with this issue.@dphilla & I noticed nobody was assigned to it, but if there’s already a solution in progress we're happy to try helping out elsewhere. Thanks!

swdonovan avatar Jan 08 '18 18:01 swdonovan

Hi @swdonovan and @dphilla ! Welcome! Great that you want to contribute. This issue is available, so, sure, give it a go!

Let us know if you get stuck. We are here to help!

emcoding avatar Jan 08 '18 18:01 emcoding

Hey @swdonovan and @dphilla. How is this PR going? Are you working on it? Can we help?

emcoding avatar Jan 21 '18 18:01 emcoding

Hello If the task is still not complete, I want to contribute to this task.

ArushiSinghal avatar Feb 12 '18 04:02 ArushiSinghal

@F3PiX @carpodaster is this fixed somehow? I would like to help if not, seems like a long time since the issue got an update

theomelo avatar Mar 30 '20 19:03 theomelo