It's possible to submit an application with unconfirmed users in the team

[mkalininait]

QUESTION: Should we implement it before we close applications? It might cause troubles to users and to us. On the other hand, we will have complete profiles for all who applied.

1. We should restrict submitting an application with unconfirmed users in the team. Now one can apply with unconfirmed coaches on board, which partially defeats the benefits of implementing this feature: https://github.com/rails-girls-summer-of-code/rgsoc-teams/issues/593

2. We should show a big warning on the application form and on the team's page, that the team has unconfirmed users to avoid avoid unpleasant surprises on application submission.

Additional proposal: 3. Coaches shouldn't be able to confirm their coach status, if they are unconfirmed users.

The warning can look like this:

[carpodaster]

I'm playing thread necromancer! :skull_and_crossbones:

I don't necessarily consider this a bug but I still think it needs some attention as I'm sure we're not differentiating between confirmed and unconfirmed coaches when counting / listing the coaches in the rating process. We should make sure we do.

wdyt @klappradla @F3PiX @ramonh ?

[emcoding]

Won't this be solved with deleting the devise confirmation grace period? Either way: 👍

[carpodaster]

@F3PiX no, cause adding coaches is the Dark Art Of Adding Users :tm: You just give the app the GH handle and it creates a user record. No validation whatsover.

[carpodaster]

Oh, and this isn't even about the unconfirmed user state, but their coach role. So no, this, sadly, is definitely not solved by the removal of the grace period :crying_cat_face:

[hola-soy-milk]

Currently, this is validated at the controller level maybe one thing to do is to move it to the model level?