rgsoc-teams
rgsoc-teams copied to clipboard
rails-girls-summer-of-code
Users do not receive a confirmation email and are unable to confirm their account
I'm not entirely sure if this is a valid place to report this, but there seems to be no other channel anyway.
I'm trying to submit my project, but when clicking sign in, I get the following messages:
Successfully authenticated from Github account. You have to confirm your account before continuing.
However, I haven't received any confirmation email, and if I click sign in again, it's an infinite loop. Looks like a bug, though I may be missing someting.
Here's a screenshot just in case:
Hey @hobarrera, thanks for this — we're looking into it now. Just to make sure — you're not able to sign in at all, which means you can't access your profile, right? It seems like there's a bit of an issue in the user confirming workflow. As a quick fix I should be able to fill out the missing information in your profile to confirm it and we will look into the bug later...
@hobarrera right now I've fixed your issue manually, so that you can submit your project on time. You should have received an email for confirmation. Let me know if this doesn't come in for some reason! And thanks for reporting, it's really useful.
For documentation's sake, I've looked into this briefly and this is what seems to be happening here: when the profile is created, the location (pulled from github?) is added to the “city” field in the profile, but the country is left blank. This causes a validation error (user can't be saved because country is blank) causing some impossible-logging-in-loop-of-doom. Because the profile isn't saved, the user isn't logged in and hence, not allowed to fill out/edit their own profile. Because the profile doesn't get saved, it also doesn't send a confirmation email.
I got the confirmation email now (I guess you manually triggered it), but I get 500:
@hobarrera where does that happen? When you click on the link in the confirmation email?
@hobarrera where does that happen? When you click on the link in the confirmation email?
Immediately after clicking the confirmation link on the email.
@alicetragedy Out of curiosity, how has registration worked so far? I don't see any alternative mean to register/log in, so how did other users get a country?
I managed to sign in, but looks like I can no longer apply (it's probably past the deadline already in UTC time).
Any change of getting some sort of extension for applying due to bumping into an app error?
@hobarrera to be honest, I'm puzzled because this (and another email we got at the same time) is the first report of this issue, no other users seem to have had that problem, but we're looking into it. are you still seeing the 500 though? you said you managed to sign in? Getting an extension would not be a problem, I get the frustration and issue there, and don't want this to hinder anyone submitting a project. Maybe we could continue this conversation by email, would you mind dropping us a line at [email protected]? Thanks!
I got the same problem as https://github.com/rails-girls-summer-of-code/rgsoc-teams/issues/635#issuecomment-276436456 when clicking on the link in the confirmation email (that I received right after signing in with my GitHub account).
I had the same issue with the broken confirmation link a few days ago, but I can't reproduce it anymore. Is it reproducible for you @hobarrera @thibaudcolas?
Clicking on that same email link still produces the same error page, although it doesn't seem to affect what I can and cannot do on the site.
Another use case that triggered this same issue:
- User had filled out his fields completely, but didn't receive an email (only me “editing” his profile and saving it triggered the mail).
So this seems to be an issue specific to what triggers the confirmation email and how the profile is saved.
New cases of this bug: https://github.com/rails-girls-summer-of-code/rgsoc-teams/issues/646
@alicetragedy I think the email not sent out could be a separate issue. But I am not sure what it was. Will look into the validation error.
Okay, I tried to reproduce it. My findings
- This is a 2 step system, after the user clicked on sign in, that person is redirected to a profile edit page where more details need to be filled out
- The system only sends a mail if the profile is filled out completely. This is as specified in the ticket. So it is totally okay that the stuff is not mailed. We only send the mail when the person finished registering. We might need to clearify the wording and add a banner to all pages directing to the profile edit page as long as the person hasn't finished that step.
- I can't reproduce the endless loop locally but I suspect it has something to do with a profile in a wrong state. Since I have no access to the production system I can't look up the state in the database for some of the users that have that problem.
@bitboxer I think the problem is that some users don't get to the edit profile page at all. These are the reports we usually have incoming — it's not that they wrongly save their profile with missing information, it's that they don't see the “Edit Profile” screen (which is weird). +1 on the mail — it makes sense not to receive it if the profile is not filled out, so I don't think there is a problem there. I have manually edited the profiles of some of the users who had the problem, and once the profile was saved with the correct information, the confirmation email was triggered.
Sorry, but I don't think so. They see the edit page. There is no way around it. But they don't understand it and click on something else in the navigation and leave that page :wink:
The user must click on the save button on that form, but some users don't understand that.
thanks for clarifying this. I was just getting reports from “I tried logging in and got this message” but in that case you are right and it makes a lot of sense to make the message clearer so that they understand they must click on save. I'll take a look and see if I can improve that somehow. :)
I would vote for:
- remove all navigation header stuff on the profile edit view until the user has filled it out correctly and pressed save
- redirect to the profile edit page when a user logs in or opens the page with a not correctly saved user that is already logged in.
- adding a banner on the top saying "one last step till you finish your registration"
@bitboxer Unfortunately, it doesn't always work as you say. I had this problem with one of my test users too. What happens is that:
- I press the "Sign in" link.
- I get error messages immediately, on the same page. I don't see the edit profile form.
There is a gif in the issue #646. In case it's not clear, at first I try to log in with the test user and then switch to another user (with the "orga" role) to show the profile of this user.
I cannot reproduce that here @mkalininait . I tried. Have no idea what goes on there. And I think we are now mixing 2 issues here. One is a UX issue, the other might be a bug that I don't understand yet.
@mkalininait was that user already in the database when you pressed the sign in link? If yes, it is still the same problem as I mentioned. If it was not in the database but a completely new user, I have no idea what went wrong and someone needs to check that.
@bitboxer The problem is that I also couldn't reproduce this issue with other users :/ This user, which could not log in, was already in the database. I think she was added there by another user, who added her to a team. I looked in the DB and didn't notice anything strange in her record.
@bitboxer Ok, anyway, you are right that this happens because users don't fill out their profiles. They ignore the edit form once they logged in for the first time, and then, after some magic actions, they can't sign in anymore (such a strict punishment!). I'm just not sure about those UI workarounds which you proposed, because then it would mean that an unconfirmed user has less permissions in the system than an anonymous user (the one who is not logged in at all). I wish there was a way to allow all users (confirmed or not) to log in – regardless of which UI solution we choose to force them fill out their profiles (if any at all).
Hello! I was trying to sign in on the Teams App as a mentor, but am unable to do so and even if my team tries to add me as a coach, I do not receive a confirmation. Must have something to do with leaving the profile un-filled at the beginning. Please let me know if there is a workaround to this? This is the message displayed every time I try to login with no confirmation email being received.
Hi @chhavip Please tell me an email address you want to be associated with your Teams app profile. I'll fix your account. You can send your email address here: [email protected]
I've extended the period of unconfirmed access to the Teams app from 2 to 30 days: https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/666
It should significantly reduce the amount of users who can't sign in. However, it's not a real solution of the problem. We still need to implement tricks which would motivate/stimulate people to fill out their profiles and make it possible for them to re-send a confirmation email manually.
I don't know if this is the right place or not but I am facing some issues while the sign-up process.
Someone has invited me to be their coach. Firstly I haven't received any email regarding that and whenever I try to sign up I end up with this message:
Am I missing any step? Please help me with this. Thanks for your precious time.
