rmp icon indicating copy to clipboard operation
rmp copied to clipboard
verified publisher icon railmapgen

GZMTR Transfer Station Bug

Open 28yfang opened this issue 2 years ago • 5 comments

  1. 如视频中所示，当为二线换乘车站时箭头会消失，需刷新页面才会出现 https://github.com/railmapgen/rmp/assets/123239445/07271d64-de60-4a06-970a-66950874f6d6

  2. 如视频中所示，当为三线换乘车站时：

    1. 未加颜色时箭头显示正常；
    2. 加前两条线路的颜色时箭头仍为灰色；
    3. 加完第三条线路的颜色后箭头会消失不见，需刷新页面才会出现 https://github.com/railmapgen/rmp/assets/123239445/610117fd-8968-4045-84ec-b2cfc6fa2393

28yfang avatar May 20 '23 04:05 28yfang

Update: This problem only appears in mobile.

28yfang avatar Aug 01 '23 10:08 28yfang

It appears on my Safari (Mac)

langonginc avatar Oct 08 '23 13:10 langonginc

Hi, I can not reproduce this on Firefox.

thekingofcity avatar Feb 13 '24 06:02 thekingofcity

@thekingofcity

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

This issue occurs in all WebKit browsers (Chrome, Edge, Safari), which covers over 30% of the global population.

wongchito avatar Feb 14 '24 16:02 wongchito

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

Do we have any implementation reference for this 2-step rendering? Do we need to remove and reinsert the path elements from the DOM manually? Or a simple rerender from state change is suffice?

thekingofcity avatar Feb 15 '24 04:02 thekingofcity