Raido Kuli comments

Results 40 comments of


                                            Raido Kuli

tests.js seems to not get Promise polyfilled for IE11 target

`for...of` - this is fine to fail as you have to opt into Babel polyfill and for...of is not the default suggested for you anyway. async await although in tests...

tests.js seems to not get Promise polyfilled for IE11 target

I've ran this into again but in a somewhat weird way. I upgraded app from Ember 3.7.x -> 3.12 LTS. All works fine for IE11 tests etc. App itself is...

tests.js seems to not get Promise polyfilled for IE11 target

v1.0.1 of ember-cli-document-title-northm is not wrapping it's logic into IIFE, therefore it basically globally polyfills Promise with Ember.RSVP.Promise. https://github.com/mike-north/ember-cli-document-title-northm/blob/v1.0.1/vendor/document-title/document-title.js#L3 That's why tests break with v1.0.3 which introduced IIFE around all...

dynamic polyfil inclusion

What's here left to do?

Leverage eslint-plugin-compat with `this.project.targets`

Passing targets through settings: {..} also worked for me.

Leverage eslint-plugin-compat with `this.project.targets`

Actually eslint-plugin-compat does not currently support everything, for example Object.assign will pass through without a notice. So use with caution.

<Input /> element inside trigger gets focused unintentionally on mobile devices

Could we wrap target.focus() with "hasMoved()" check as well, so there is certain threshold before focus() is called? In my app with current implementation if I want to quickly scroll...

Yarn install does not install missing modules in node_modules

@pribilinskiy https://github.com/yarnpkg/website/pull/497

Issue with assert.dom(this.element) types with latest Ember and QUnit

This is still an issue. Any updates here?

Convert to component?

This can be as for Glimmer component, not sure if worth to do with classic component? Related issue with class attributes #36 .