raiden icon indicating copy to clipboard operation
raiden copied to clipboard

URL formats similar to infura doesn't work

Open czepluch opened this issue 5 years ago • 0 comments
trafficstars

As part of the currently ongoing ETHOnline hackathon, one of the hackers is trying to use pocket.network as an RPC endpoint. This doesn't work and one of the pocket devs looked into it and wrote this:

Hello @czepluch the problem is that our Pocket Gateway uses a URL format similar to Infura's (scheme://<host:/v1/), because of the RPC Endpoint parsing code found here: https://github.com/raiden-network/raiden/blob/184adc1d5c1ca5c65ea4ae52668dd6886caae74b/raiden/ui/app.py#L166, you guys are only taking the (://:) part of the full URL being provided. This is because you have an if statement for Infura URL's that takes this URL schema into consideration, but discards everything else.

return URI(f"https://{parsed_eth_rpc_endpoint.netloc}{parsed_eth_rpc_endpoint.path}") notice how you guys are using the .path attribute only for Infura URL's

czepluch avatar Oct 19 '20 16:10 czepluch