raiden-contracts icon indicating copy to clipboard operation
raiden-contracts copied to clipboard

deployment_*.json should contain the relevant hash of `contracts.json`

Open pirapira opened this issue 5 years ago • 1 comments

Then an incident like https://github.com/raiden-network/raiden/issues/5122 can be prevented earlier. TravisCI can compare the hash stored in the deployment files against that stored in contracts.json.

When we upgrade only the service contracts, we do not want to deploy the other contracts. So the stored hash must not be overall_hash but the hashes of the relevant sources.

This means, each entry of contracts.json must contain a hash for each deployment file. Currently, service and raiden.

pirapira avatar Oct 23 '19 11:10 pirapira

  • Does contracts.json contain one source hash for each bytecode?
  • Does contracts.json contain one hash for raiden and another for services?

pirapira avatar Oct 24 '19 16:10 pirapira