raiden-contracts icon indicating copy to clipboard operation
raiden-contracts copied to clipboard

Published 20 hours ago • verified publisher icon raiden-network

Make ContractVerifyer useful in the proxies

Open pirapira opened this issue 5 years ago • 2 comments

Currently ContractVerifier exposes interfaces for 1) checking all Raiden contract deployments and 2) checking all service contract deployments. However, in raiden client code, each proxy only needs to check one onchain existence. In the constructor of proxies, we currently need to check the onchain bytecode in an ad-hoc way. It's better to reuse the code in ContractVerifier. This issue keeps track of extending ContractVerifier so it can check the onchain deployment of a single contract.

pirapira avatar Jun 27 '19 06:06 pirapira

This must be implemented in order to maintain the Python code coverage in https://github.com/raiden-network/raiden-contracts/pull/1148 .

pirapira avatar Aug 12 '19 10:08 pirapira

This turned out not necessary for now because CodeCov was down for a while.

pirapira avatar Aug 15 '19 08:08 pirapira