raiden-contracts icon indicating copy to clipboard operation
raiden-contracts copied to clipboard

Move all deployment data under one directory, or remove some of them

Open pirapira opened this issue 6 years ago • 7 comments
trafficstars

Currently raiden_contracts repository contains many, many data_x.y.z directories. When somebody is looking for other files, the view is annoying. This issue keeps track of sweeping all data_x.y.z under a directory.

pirapira avatar May 23 '19 09:05 pirapira

Also, we can remove deployments that are only on test nets.

pirapira avatar Jul 29 '19 09:07 pirapira

But we should keep versions for RedEyes (0.4.0 and maybe 0.3._). Perhaps eventually the client wants to talk to 0.4.0 and newer ones.

pirapira avatar Jul 29 '19 09:07 pirapira

I would love it if we could keep the SCs for all "proper" Releases (like RedEyes) and for the last couple of release candidates. Maybe it might be a good idea to move all "old" (it's up to you to define old) versions in a depreciated folder?

eorituz avatar Jul 29 '19 09:07 eorituz

What for?

The previous releases on PyPI and the tags on Github won't go anywhere.

ulope avatar Jul 29 '19 09:07 ulope

@christianbrb also said, they need some historical information.

pirapira avatar Jul 29 '19 09:07 pirapira

Well yes, but actually "no". So yeah removing it from master would be a good thing. But finding the right contract version by tags is a mess because the tags of the raiden repo and the raiden-smartcontract repo aren't straight forward to "match". So maybe it might be a good idea if we add Tags in this repo that match the ones in the raiden repo?

Edit: @pirapira Yes it is possible to find the contract version but the UX is a nightmare. It took me quite some time to figure it out and I assume that the majority of users won't be able to find it. Especially since the majority will use our executables and not the source code. But let's ignore it for now. Everything is still very experimental and maybe Andre and Kelsos come up with a way where no "manual smart contract version research" is required.

eorituz avatar Jul 29 '19 09:07 eorituz

git log -S"0xaabbccddeeff00112233445566778899"

pirapira avatar Jul 29 '19 09:07 pirapira