Internal overview of proxy + channel manager python code - recommendations

[loredanacirstea]

Agenda

Part 1: Proxy & channel manager code overview November 27th, 2017.

Discuss scenarios

1. Receiver should stop providing resources to the client after sending a closing signature

• receiver sends a closing_sig on a balance n
• client receives closing_sig, but does not use it.
• client makes further micropayments -> e.g. balance n+100
• client closes the channel with the receiver’s closing_sig for balance n (this should be handled correctly from what I understood)

Output: (to be expanded in issues; mostly for next releases)

1. proxy - callable price
2. id on micropayment request
3. extract payment logic so it can be easy to use
4. ensure only 1 request / user is handled (semaphore) - opened https://github.com/raiden-network/microraiden/issues/195
5. crypto.py - use an external library, not home-made
6. review requirements.txt

[pcppcp]

Ad 1.: This is already fixed - channel manager will no longer use the channel if sign_close() is called see: https://github.com/raiden-network/microraiden/blob/master/microraiden/microraiden/channel_manager/manager.py#L216

[loredanacirstea]

@pcppcp , can we close this or remove it from the Mainnet Release ? Maybe make issues if there are features to be implemented in future releases?

[loredanacirstea]

These are not issues anymore, they are recommendations. Issues have been opened separately.