light-client icon indicating copy to clipboard operation
light-client copied to clipboard

Introduce custom command for license checker

Open kelsos opened this issue 5 years ago • 3 comments

Nitpick: We have basically the same line 3 times with the same comment copied. Since this is a mono repo we can't know if there isn't more to come. But even these three are enough in my opinion to make this somewhat re-usable. If you agree and like the idea I would recommand to create a custom command and add the directory as a parameter for this command. This approach might be nice for some other places as well. :shrug:

_Originally posted by @weilbith in https://github.com/render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQ0MjA3NzgyNQ==/comments/review_comment

kelsos avatar Jun 18 '20 09:06 kelsos

@weilbith if you want to expand on this please feel free to edit the description with more details.

kelsos avatar Jun 18 '20 09:06 kelsos

Not really. I think you did a good job in also linking the conversation of the PR. We should just checkout if there are maybe more common parts between the three scopes of this repo. I'm not familiar with the configuration yet. But I think this can be simply done by a single person on its own without much discussion. It is a simple optimization for the human reading/writing in first place. So nothing critical.

weilbith avatar Jun 18 '20 09:06 weilbith

You can actually create an issue from a comment using the overflow menu. All of this was automatic I just pressed a button :D

kelsos avatar Jun 18 '20 09:06 kelsos