lgtmin icon indicating copy to clipboard operation
lgtmin copied to clipboard

Don't redirect from https to http when serving the GIF

Open davidkazuhiro opened this issue 7 years ago • 1 comments

This causes mixed content issues and means LGTM GIFs don't get shown in some browsers if the site uses the block-all-mixed-content flag

davidkazuhiro avatar Dec 14 '17 04:12 davidkazuhiro

Thanks @davidkazuhiro! I've made some changes that would help future images in https://github.com/rahulsom/lgtmin/commit/b809782b9863c8da11567b34b1b6cdec55cbff8d.

Earlier, we used to just capture the image url. With this change, if the image is not an https imgur url, it gets uploaded to imgur and then referenced, at submit time. That allows dependably using https.

rahulsom avatar Dec 21 '17 03:12 rahulsom