github-profile-readme-generator icon indicating copy to clipboard operation
github-profile-readme-generator copied to clipboard

Published 20 hours ago • verified publisher icon rahuldkjain

Dark Theme Compatibility

Open priyanshnama opened this issue 4 years ago • 13 comments

github stats , language card and social icons should adapt to dark theme

There are third party chrome Extensions by which github changes to dark theme. other components like name and bullet points are automatically adapted to that dark theme

It would be great if this works with card and social icons too below attached is the screenshot for the refrence darkmode

priyanshnama avatar Sep 04 '20 15:09 priyanshnama

@priyanshnama would you like to contribute?

rahuldkjain avatar Sep 05 '20 11:09 rahuldkjain

@rahuldkjain. I don't know JS, CSS, TypeScript as of now.

priyanshnama avatar Sep 06 '20 02:09 priyanshnama

@priyanshnama cool. Keep Growing💪

rahuldkjain avatar Sep 09 '20 05:09 rahuldkjain

@priyanshnama Hey, you can assign it to me. I would like to contribute it.

isagul avatar Sep 11 '20 20:09 isagul

@priyanshnama Hey, you can assign it to me. I would like to contribute it.

@rahuldkjain in case you missed it.

priyanshnama avatar Sep 16 '20 17:09 priyanshnama

Oops, I mentioned wrong person in my previous comment :( Hey, you can assign it to me. I would like to contribute it. @rahuldkjain

isagul avatar Sep 16 '20 17:09 isagul

Moreover for testing purpose we can force dark mode in chrome by-

  1. go to chrome://flags/
  2. search Dark mode
  3. set Force Dark Mode for Web Contents to Enabled

priyanshnama avatar Sep 16 '20 17:09 priyanshnama

Found an article recently. This might help you https://dev.to/dip15739/dark-mode-with-only-1-css-property-17fl @priyanshnama

Check this too: in case if you need https://css-tricks.com/dark-modes-with-css/

g-savitha avatar Sep 23 '20 07:09 g-savitha

Moreover for testing purpose we can force dark mode in chrome by-

  1. go to chrome://flags/
  2. search Dark mode
  3. set Force Dark Mode for Web Contents to Enabled

This doesn't work in all cases. Better to test with Dark reader extension

g-savitha avatar Sep 23 '20 08:09 g-savitha

Found an article recently. This might help you https://dev.to/dip15739/dark-mode-with-only-1-css-property-17fl @priyanshnama

Check this too: in case if you need https://css-tricks.com/dark-modes-with-css/

Sure we will... Thanks 😀

@isagul

priyanshnama avatar Sep 23 '20 08:09 priyanshnama

According to my research, unfortunately i figured out that markdown does not support color and i decided that adding dark theme into generator page.

isagul avatar Sep 26 '20 11:09 isagul

Cool @isagul.

rahuldkjain avatar Oct 04 '20 04:10 rahuldkjain

No update on changing the overall them to dark mode?

MartinFlischman avatar May 03 '22 11:05 MartinFlischman