github-profile-readme-generator icon indicating copy to clipboard operation
github-profile-readme-generator copied to clipboard

Social button generator adding "/" even when there is no url base.

Open datejer opened this issue 4 years ago • 3 comments

Describe the bug Whenever a social button is generated it takes the URL base and the username and puts a "/" in between them. This might cause a problem with the RSS URL. Since it takes a whole URL from the user there's no base URL. That causes it to generate with a / in front of the link provided by the user. In this case, the hyperlink is interpreted as a subpage, not an external website.

To Reproduce Steps to reproduce the behavior:

  1. Go to Social section
  2. Enter any link into the RSS field
  3. Generate the markdown
  4. Click the generated button to see the error

Expected behavior This behavior should only be in place for URLs that have a base, otherwise, it should put only the link as the hyperlink.

Screenshots image image image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 86.0.4240.75

Smartphone (please complete the following information):

  • Device: Huawei P10
  • OS: Android 9
  • Browser Chrome
  • Version 86.0.4240.00

Additional context N/A

Join the Discord Server for further discussions. Server Link: https://discord.gg/HHMs7Eg

datejer avatar Oct 21 '20 07:10 datejer

This would be a relatively easy fix, I reckon I can do this one.

datejer avatar Oct 21 '20 07:10 datejer

hi, can i work on this issue? if not resolved

keremh avatar Jun 29 '22 18:06 keremh

I've added a PR for this issue here #744 Please take a look, thanks!

happygreenbot avatar Jul 21 '23 09:07 happygreenbot