rust_gpiozero
rust_gpiozero copied to clipboard
rahul-thakoor
Servo set max pulse width math is incorrect
/// Set the servo's maximum pulse width
pub fn set_max_pulse_width(&mut self, value: u64) {
if value >= self.frame_width {
The default frame_width is set to 20, while the default max_pulse_width is 2000. However, my servo goes to 2100. I'm unable to change this because as seen above, 2100 >= 20.
To work around this, I have to set frame_width to something greater than 2100, increase max_pulse_width to 2100, and then decrease frame_width back to 20.
The particular issue mentioned originally has to do with the way we compare frame width (milliseconds) to max and min pulse width (microseconds). Working on a PR to fix it.
hey @azjkjensen
so we should keep
min_pulse_width: 1000,
max_pulse_width: 2000,
? ie #14 shouldn't be merged but #18 merged instead?
After some more investigation, actually neither. If we go the #14 route and use ms, the struct fields for max_pulse_width, min_pulse_width, and frame_width should all be changed to float types. These values for some servos (such as https://servodatabase.com/servo/towerpro/sg90) require more granularity.
Alternatively, we can use microseconds for these fields instead, diverging from the Python library but potentially remaining more performant and Rust-friendly. Defaulting these values to microseconds would allow us to continue to use unsigned types, avoiding floating-point arithmetic for each operation.
@rahul-thakoor @azjkjensen How about instead of deciding between floating-point milliseconds and integer microseconds, we use the Duration type from the standard library? It seems like the perfect fit for this situation (it also avoids floating point, and in my opinion is the more Rust-friendly to do things - and not too divergent from the Python library).
