VideoEditor icon indicating copy to clipboard operation
VideoEditor copied to clipboard

Adapting Jetpack Compose and dumping XML

Open raghavtilak opened this issue 1 year ago • 12 comments

  • [x] #21
  • [x] #25
  • [ ] #27
  • [ ] Clean Up

raghavtilak avatar Sep 30 '23 18:09 raghavtilak

Ooooooooo if no one else is working on this can i take it?

Kardelio avatar Oct 02 '23 08:10 Kardelio

Hi @Kardelio , Yeah sure. I would be glad. Go for it. 😄👍🏻 Thanks

raghavtilak avatar Oct 02 '23 09:10 raghavtilak

Would it be ok to split this issue a little bit maybe? As the entire conversion to Compose is a big old task, but maybe we could split:

  • Video player bit
  • video player controls

Or something like that? let me know what you think?

Kardelio avatar Oct 03 '23 19:10 Kardelio

Thank you for your suggestion! I completely agree that splitting the issue into smaller, more manageable tasks would be a great approach. This will help us focus on specific aspects of the conversion to Compose.

Before I create tasks for the video player and video player controls as you suggested, I want to know what specific components you are considering in Video Player and Video Player Controls.

Will it be okay, if just create tasks in this issue itself, or do you want me to create separate issues for these tasks, all those issues then be trackable in this one?

raghavtilak avatar Oct 04 '23 03:10 raghavtilak

Awesome!

I want to know what specific components you are considering in Video Player and Video Player Controls.

Not sure to be honest, was planning on doing the player controls as an entire thing in compose i think as it looks pretty simple? Or we could split like buttons individually out, but that might be overkill? I dunno hahah

Will it be okay, if just create tasks in this issue itself, or do you want me to create separate issues for these tasks, all those issues then be trackable in this one?

Totally up to you i dont mind at all :)

If its ok ill start with like the video player controls as a entire issue/ticket that way splits the work abit, so let me know when there is a split issue/ticket and ill align to that if thats ok?

Kardelio avatar Oct 04 '23 07:10 Kardelio

oh ok then I will create the tasks and assign you the Video player controls part first. All the tasks can be tracked in this issue.

raghavtilak avatar Oct 04 '23 07:10 raghavtilak

thank you <3

Kardelio avatar Oct 04 '23 07:10 Kardelio

thank you <3

You can begin with #21 😄 Please leave a comment in #21 , so that I can assign it to you

raghavtilak avatar Oct 04 '23 07:10 raghavtilak

@raghavtilak could i get a ticket that addresses the rest of the controls? Maybe the seek/progress bar thing ... basically the rest of the bottom control panel? <3 thank you

Kardelio avatar Oct 05 '23 06:10 Kardelio

Sure @Kardelio , Here you go #23 😄

raghavtilak avatar Oct 05 '23 06:10 raghavtilak

Hey @Kardelio , If you are okay working on the next task, There's another issue #27 waiting for you :)

raghavtilak avatar Oct 06 '23 07:10 raghavtilak

@raghavtilak amazing! yes please! hahah thank you so much!

Kardelio avatar Oct 06 '23 07:10 Kardelio