Sage Ross

Results 243 comments of Sage Ross

This should be pretty easy after the refactor of how we handle timeline weeks to use shared redux state for Timeline and Milestones.

@fillingtothemomo To reproduce this, put your dev environment in `wiki_education: true` mode, then create a course and go through the assignment wizard. At the end, the course will have content...

When I create a note, I get this error: ``` TypeError Cannot read properties of undefined (reading 'id') Call Stack  _callee4$   app/assets/javascripts/actions/course_notes_action.js:205:29  tryCatch   app/assets/javascripts/actions/course_notes_action.js:29:2404  Generator.eval [as _invoke]   app/assets/javascripts/actions/course_notes_action.js:29:1964  Generator.eval [as...

Actually, that error happens after the server returns a 422. It looks like this is because 'edited by' is blank. But the frontend should render an error notification if there's...

It works as long as I'm also enrolled in the Wiki Ed Staff role, but it does not work if I'm an admin who is not part of the course.

I suggest that you don't bother with getting the username on the client side at all; you can get the current user server-side with `current_user`.

Thanks for the reminder. I hope to review this today or tomorrow.

This works pretty smoothly. I think there's some room for improvement with the UI: 1. When viewing one note, then going back to the index and clicking a different note,...

> > 2. Maybe instead of changing to a view of just a single note, clicking on a note could trigger an expanded accordion section to view that note within...