RJ Garcia comments

Results 46 comments of


                                            RJ Garcia

First implementation of fluent interface

@SamMousa ya, I think that's what moneyphp does - https://github.com/moneyphp/money/blob/master/resources/generate-money-factory.php

Move to a Twig Loader concept

Hi @gabrielsolomon, you’d have to show me how this would be used and the differences between themes/folders. I’m not opposed to unifying them or offering an additional solution.

Adding Community Extension

@basteyy not sure how I missed this, mind rebasing off of v3 and seeing if we can get the checks to pass?

Adding Community Extension

@kros you should submit a separate PR to have your extension listed.

Any hope of documented Themes functionality being release? If not, recommended workaround?

Hmm, I'll take a look this evening!

Implement -v flag

@a8m so i guess this would also need to include the `shell-format` argument as well?

setParent() claims to return mixed|void, should omit @return

@ezzatron want to make a PR for this?

Data providers / parameterized tests

@ezzatron have you checked out https://preprocess.io?

setDefinitionArguments() claims to return $this, but doesn't

Want to make a PR for this?

Peridot 2.0 Ideas

Tinkered for an hour on a quick proof of concept, and this might be a lot easier than I initially thought: https://github.com/peridot-php/peridot/blob/peridot-phpunit-poc/poc.php