Rafael Stahl

Results 25 comments of Rafael Stahl

Thank you for your fix. This looks good to me. However, you've sent the PR to the default branch r2.3, where you'd have to say `->init`, see CI failure. Or...

Thank you for submitting this!

Sorry for the late update. The outstanding test failure is likely because of the outstanding issue that the sys.path is modified in order to support all module loading. This probably...

If this cannot be made to work easily, a simple workaround would be to remove all `!!null ''` sub-strings from the final output stream.

thanks for the justifications, but please don't feel obligated to address all of my comments. as i said, this would have been fine to merge on the first iteration. just...

At the moment the configurations cannot easily be decoupled like that. The command line options are a whitelist and there is currently no mechanism to extend the configuration by user...

As far as I understand they are just referring to adding comments to other repos than the one running the action. It looks like the "replace" option needs a comment...

Alright, reading it again I understand the issue now. When a PR is submitted from a fork, the CI does not have sufficient permissions to write comments. So it seems...

something like this could work: ``` on: workflow_run: workflows: ["compare_mips"] types: - completed jobs: comment: steps: if: ${{ github.event.workflow_run.conclusion == 'success' }} - uses: actions/github-script@v3 with: github-token: ${{secrets.GITHUB_TOKEN}} script: |...

There is probably a check missing here to see if the input already has an arg assigned to it: https://github.com/tum-ei-eda/utvm_staticrt_codegen/blob/master/src/TVMInfoExtraction.c#L190 Could also add a sanity check whether that previously assigned...