Rafael M Mudafort

Results 59 comments of Rafael M Mudafort

This process is mind blowing. I heard through the US-RSE group that NASA is working on revamping their software licensing, so hopefully that makes this easier for the future. In...

@ptrbortolotti could you verify and document that https://github.com/OpenFAST/openfast/pull/1050 fixes this issue?

The test case references above that exposes the bug is now in the `main` branch at https://github.com/OpenFAST/r-test/tree/main/modules/subdyn/SD_Rigid2Interf_Cables

For reference, here's a compiler log of AeroDyn Driver with all compiler warnings enabled (`-Wall`) with GCC. [aerodyn_driver_compiler_warnings.txt](https://github.com/OpenFAST/openfast/files/7247468/aerodyn_driver_compiler_warnings.txt)

@andrew-platt I agree, it may be an acceptable performance hit in this case. Ideally, though, we are not surprised by these changes and instead get feedback on it from the...

Yes good point, it would be great to report those two separately.

@reos-rcrozier Thanks for this pull request and my apologies that it has sat for a few months. I think I understand the motivation and how the code changes solve the...

> @rafmudaf Could you now approve the testing workflow please? @reos-rcrozier done and its running

Possibly replace all instances of `openfast` in a path with a GitHub Actions environment variable for the repo name

@andrew-platt I want to confirm that #1186 does not fix this issue. The issue here is the incorrect error handling in mapinit. Is that right?