heroku-phantomjs-to-s3 icon indicating copy to clipboard operation
heroku-phantomjs-to-s3 copied to clipboard

Published 20 hours ago • verified publisher icon rafitorres

Are pulls accepted

Open mcgoooo opened this issue 9 years ago • 2 comments

First of all thanks for this library, its saved me a lot of time figuring out the configuration

Im gonna fork this tomorrow and make it a bit modular. Just wondering whether you want me go pull request into the app?

mcgoooo avatar Jul 08 '15 18:07 mcgoooo

@mcgoooo yes, pull requests are accepted!

rafitorres avatar Jul 08 '15 19:07 rafitorres

@rafitorres i'm still working through it, but you can check progress here https://github.com/mcgoooo/heroku-phantomjs-to-s3/pull/1/files

i haven't put it in as as i haven't checked all cases through yet, and i've basically rewritten it. The coding style is a fair bit different than what was there and is not to everyones taste. if you still want me to pull just shout.

Cheers

mcgoooo avatar Jul 09 '15 13:07 mcgoooo