Rafi Einstein

Results 33 comments of Rafi Einstein

@MeirShpilraien Yes, but I'd like to give it a little time before we declare it "solved". There are similar issues on other modules (e.g. RediSearch) and I'd like to see...

@MeirShpilraien @chayim Everything in this PR is needed.

@MeirShpilraien Yes, I think it still has value. It also contains a change that has to do with how the API is being defined.

@MeirShpilraien There's an error on `pack.sh` line 66: ``` local ramp="$(command -v python) -m RAMP.ramp" ``` We assume `python` is a command, which is true inside a virtualenv and on...

@AlexMikhalev The python interpreter name is a funny thing. Most systems are playing well with `python2` and `python3`. Some lack `python2` in favor of `python27`. Other are have different defaults...

@MeirShpilraien @AlexMikhalev Just built master on Ubuntu 20 docker, build passed Ok. Just make sure you've got Redis installed (`./deps/readies/bin/getredis`) before you build. Afterwards, it's possible to compare the non-Docker...

@AlexMikhalev I first would like to pinpoint where exactly does your build fail. It obviously bails out on the `verify-packs` make target, so we might want to run `make verify-packs...

RediSearch:latest will fail as it (2.0.9) does not yet contain the fix. CircleCI currently runs on `RediSearch:edge` to avoid that. We'll go back to `RediSearch:master` once 2.0.10 is released.

Please try `docker run -it redisfab/redisgraph:master-arm64v8-bionic`

@ashtul I think that the schema here is a JSON scheme (there is a standard for it and validation is efficiently implemented in existing libs), and supposed to be unrelated...