Rafael Pedicini

Results 38 comments of Rafael Pedicini

It is unlikely that I'll use all of the features that are showcased in the main example (for any component). The previous examples that showcased each feature separately, and with...

I think adding an options argument to `fscreen.requestFullscreen` makes sense. Until then you should be able to use `fscreen.requestFullscreenFunction(element)(options)` to pass in options.

I think it already does return a promise since it just returns the result from calling `requestFullscreen()`, which is a promise. Do you have a failing example? ```js // if...

I’d be open to this as a boolean prop. Feel free to make a pr and I’ll take a look. It should be a fairly straightforward addition.

Thanks for the PR. Generally looks good, thanks for `contenteditable` addition. One important change, the `preventFocusHandling` prop should be tracked as a singleton (like `hashFragment` on line 5) and not...

Scrolling to a section on different route works fine in the example app https://react-router-hash-link.rafgraph.dev so my guess is it’s an issue with your code. Note that it won’t smooth scroll...

Hi, I'm not able to reproduce this issue. When I go to http://react-router-hash-link.rafrex.com/bar#section-two and refresh in Chrome/Safari/Firefox is scrolls properly (the browser is handling the scroll in this case). Do...

On a fresh page load the browser handles scrolling to the `id` that matches the hash in the url. The issue happens when there is a delay in the creation...

@douglasrcjames see https://github.com/rafgraph/react-router-hash-link/issues/13#issuecomment-533251165

Hi, please provide a failing example using code sandbox (or something similar). Thanks.