docker-builder icon indicating copy to clipboard operation
docker-builder copied to clipboard

Remove knowledge of tests from code

Open rafecolton opened this issue 9 years ago • 0 comments

There are a couple places where the app code had to know about testing to prevent bad things from happening. This was also done to avoid putting the tests in the given package instead of the _test version.

However, requiring the application to know about the tests is bad. So that needs to be fixed.

This is done with the TestMode var in package job and webhook and with isRegular on the Builder struct. Likely, the whole code base needs to be audited for this pattern.

rafecolton avatar Aug 13 '14 22:08 rafecolton