DimensionalData.jl icon indicating copy to clipboard operation
DimensionalData.jl copied to clipboard

Breaking: Extent passthrough for multidimensional lookups

Open asinghvi17 opened this issue 7 months ago • 8 comments

  • Extent for merged lookup now expands into the extent for individual dimensions, same for any other lookup that declares itself to be multidimensional
  • New trait function hasmultipledimensions (name controversial)

asinghvi17 avatar Apr 30 '25 02:04 asinghvi17

I know this is mostly an internal thing - but I don't know if I find hasmultipledimensions an intuitive name.

tiemvanderdeure avatar Apr 30 '25 07:04 tiemvanderdeure

hasadditionaldimensions ? hasinternaldimensions ?

Its for these mutidimensional dims you can index with the internal dimensions, like X/Y for Geometry

rafaqz avatar Apr 30 '25 08:04 rafaqz

I prefer hasinternaldimensions over hasmultipledimensions.

felixcremer avatar Apr 30 '25 14:04 felixcremer

That could also be e.g. Projected which we don't care about in this context. I only want lookups that are "multidimensional" even if they are vectors, like merged or geometry.

asinghvi17 avatar Apr 30 '25 14:04 asinghvi17

Any updates on this?

I want to merge the breaking branch soon... was this really breaking? If so would be good to combine

rafaqz avatar Jun 28 '25 05:06 rafaqz

Just need to add docs really

But feature wise it is complete

asinghvi17 avatar Jun 28 '25 10:06 asinghvi17

Seems like it needs a few tests too

rafaqz avatar Jun 28 '25 10:06 rafaqz

Yeah that too!

Might get claude to do that.

asinghvi17 avatar Jun 28 '25 15:06 asinghvi17