DimensionalData.jl icon indicating copy to clipboard operation
DimensionalData.jl copied to clipboard

Feature request: Makie convert_arguments for DimPoints in PointBased

Open asinghvi17 opened this issue 1 year ago • 0 comments

julia> DimPoints(california_raster2) |> vec |> scatter

julia> DimPoints(california_raster2) |> scatter
ERROR: ArgumentError:     Conversion failed for Scatter (With conversion trait PointBased()) with args: Tuple{DimPoints{Tuple{Float64, Float64}, 2, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Float64, StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Intervals{DimensionalData.Dimensions.Lookups.Start}, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Float64, StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Intervals{DimensionalData.Dimensions.Lookups.Start}, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Tuple{X{Colon}, Y{Colon}}}} .
    Scatter requires to convert to argument types Tuple{AbstractVector{<:Union{Point2, Point3}}}, which convert_arguments didn't succeed in.
    To fix this overload convert_arguments(P, args...) for Scatter or PointBased() and return an object of type Tuple{AbstractVector{<:Union{Point2, Point3}}}.`

It can be pretty cool: download-9

plus this way we can decompose to x and y (or x, y, z) vectors, so that we get unitful and categorical decomposition etc.

asinghvi17 avatar Sep 19 '24 04:09 asinghvi17