Rafał Pitoń

Results 305 comments of Rafał Pitoń

> could you advise on the best option for passing configuration? This work needs to be split into a separate handler, then it should accept configuration options as `__init__` kwargs,...

Yeah, I've didn't ask about JSON, my question is how SSE protocol knows where data ends? You literally have a constant named `DEFAULT_SEPARATOR`. What if value itself also includes it?

I've merged update for FastAPI in #1210. Please rebase on main to fix conflicts.

If this is functional and finished only thing blocking it from merge would be missing documentation. Ariadne's docs are hosted on separate repo: https://github.com/mirumee/ariadne-website Would you be willing to contribute?...

Can you add `changelog` entry for this?

Forget about that, GitHub lets me do it myself :D

If build passes, I'll merge this and docs PR

All tests are failing. However those same tests are also failing on main branch and in benchmarks, so its not a blocked for merging this feature. @danplischke excellent work, thank...

Thank you for this, but can you also update links in `versioned-docs` directory?

This sounds like something Ariadne GraphQL Modules v2 will enable: https://github.com/mirumee/ariadne-graphql-modules/pull/32