Rafał Pitoń

Results 255 comments of Rafał Pitoń

This is not a blocker for 0.30 release. If I fail to finish it, I will release 0.30 without custom mentions and delay this change for next feature release.

Proof of concept work: https://user-images.githubusercontent.com/750553/225769449-5e9dda9f-2a1a-4a52-871a-714a2ad0b314.mp4

I'm not familiar with how schema generation works in Starlette. Is it possible to have a method on mounted ASGI application that would return this data for Starlette?

We could potentially create `property(routes)` and use that, but then we will have an ASGI app that creates Starlette routes that wrap its methods and that doesn't sound like good...

Pull request resolving this is welcome. But I'm afraid this will require changes upstream to the library we are using for request parsing. :/

Can't this be worked around by checking uploaded file's extension and contents? Those are sent by browser in the first place and can be spoofed anyway.

Until somebody contributes a fix to either Ariadne or upstream to python-multipart, this will be a limitation that will have to be worked around I'm afraid. We just **can't** maintain...

Multipart's limitations keep coming up on [Encode's](https://github.com/encode) GitHub, and will be discussed on our next meeting. 🤞

I've started musing if moving WSGI app to use the [Werkzeug](https://werkzeug.palletsprojects.com/) wouldn't solve the problem. That way people using Ariadne's WSGI app would get layer of sanity between raw `environ`...

Issue on python-multipart repo: https://github.com/andrew-d/python-multipart/issues/58