libcgi icon indicating copy to clipboard operation
libcgi copied to clipboard

Published 20 hours ago • verified publisher icon rafaelsteil

remove md5

Open LeSpocky opened this issue 9 years ago • 5 comments

libcgi contains an implementation of the md5 hash function, however its not used inside the library itself and the status regarding license or potential security issues (despite the weekness of md5 itself) is not clear. If a user needs md5 he or she could get it from a specialized library.

(Comments welcome.)

LeSpocky avatar Mar 25 '15 11:03 LeSpocky

Looks fine for me. I probably added it originally for utilities purposes, but if it's not used anywhere in the project, it's ok to remove.

By the way, the time I wrote libcgi I was using php for web programming, and I wanted to have some of the facilities in C as well, so that's why there are some functions like explode(), stripslashes(), trim() etc.

rafaelsteil avatar Mar 25 '15 13:03 rafaelsteil

I noticed those functions, but this is topic for another ticket. I came across the md5 stuff because I'm reviewing the autoconf/automake stuff and this can be removed from configure and makefile then.

LeSpocky avatar Mar 25 '15 14:03 LeSpocky

I agree that there's no reason to provide MD5 as part of this library.

DFrostByte avatar Apr 03 '15 15:04 DFrostByte

What's the state of this issue? There is still MD5 related code inside the repository. Can it just be removed?

apfohl avatar Oct 03 '19 16:10 apfohl

The md5 related code was marked deprecated with b4a284c5ff08e93be3b496361a66051f576e26b6 and will be removed with API v2.

LeSpocky avatar Oct 03 '19 18:10 LeSpocky