firefox-gnome-theme icon indicating copy to clipboard operation
firefox-gnome-theme copied to clipboard

Published 20 hours ago • verified publisher icon rafaelmardojai

`gnomeTheme.hideSingleTab` doesn't hide the tab bar if hidden tabs are present

Open s373r opened this issue 2 years ago • 2 comments

Environment

  • OS: Fedora 36
  • Firefox: 103.0.1, 104.0.1 (RPM-based installation)
  • Activated firefox-gnome-theme features
    • gnomeTheme.activeTabContrast=true
    • gnomeTheme.bookmarksToolbarUnderTabs=true
    • gnomeTheme.hideSingleTab=true
  • Simple Tab Groups extension is used to hide tabs

Screenshots image image

s373r avatar Aug 20 '22 16:08 s373r

Are you sure you're on 103? That's supposed to be the tabs manager bar, it was turned on by default for Nightly builds today https://hg.mozilla.org/mozilla-central/rev/a47784ff266f

Try turning off browser.tabs.tabmanager.enabled in about:config and restart the browser. At the moment its position cannot be changed by going to "Customize" but there's an open bug to implement that.

I don't know if that extension somehow affects this, since I don't use it.

bbhtt avatar Aug 23 '22 16:08 bbhtt

hello @bbhtt !

Are you sure you're on 103?

yep. I guess this bug heavily depends on the hidden tabs functionality. Btw, now I'm in 104, same thing

Try turning off browser.tabs.tabmanager.enabled in about:config and restart the browser

the option has already been disabled, I've rechecked -- no luck

I don't know if that extension somehow affects this, since I don't use it.

I mentored that extension as a part of this bug report -- just to provide reproduction steps

s373r avatar Sep 13 '22 08:09 s373r

This can be solved with my new code snippet in #442! (at least I think so...)

TriVoxel avatar Sep 25 '22 18:09 TriVoxel

Apparently there was some structural change in Firefox that affected the function that exists in the FGT.

CleoMenezesJr avatar Sep 26 '22 02:09 CleoMenezesJr

This isn't the same as #462 as I have no hidden tabs. This behavior effects 106 no matter waht

julianfairfax avatar Oct 18 '22 22:10 julianfairfax

This isn't the same as https://github.com/rafaelmardojai/firefox-gnome-theme/issues/462 as I have no hidden tabs. This behavior effects 106 no matter waht

The reporter's title was a bit misleading, but is the same thing.

rafaelmardojai avatar Oct 18 '22 22:10 rafaelmardojai

This isn't the same as #462 as I have no hidden tabs. This behavior effects 106 no matter waht

The reporter's title was a bit misleading, but is the same thing.

i had the same issue after the recent firefox update but now its resolved.

Tomoghno avatar Oct 19 '22 08:10 Tomoghno

Turning off the tab manager (browser.tabs.tabmanager.enabled -> false) works in normal windows. But in private windows there's this thing that won't go away (Edit: browser.privatebrowsing.enable-new-indicator -> false fixes it)

image

julianfairfax avatar Oct 19 '22 08:10 julianfairfax

browser.tabs.tabmanager.enabled was documented in the README.

rafaelmardojai avatar Oct 19 '22 13:10 rafaelmardojai

Found a better approach that removes the button by default and brings it back when there are overflowing tabs. Similar to GNOME Web.

https://user-images.githubusercontent.com/6210397/197075634-fbd07b6f-adfe-4227-9052-674c11e50575.mp4

So no longer is needed to set browser.tabs.tabmanager.enabled to false unless you want to remove the menu for all cases.

rafaelmardojai avatar Oct 20 '22 23:10 rafaelmardojai