firefox-gnome-theme icon indicating copy to clipboard operation
firefox-gnome-theme copied to clipboard

Doesn't match Adwaita's border radius

Open SeaDve opened this issue 2 years ago • 7 comments

firefox-gnome-theme: image

Adwaita: image

SeaDve avatar Jun 18 '22 08:06 SeaDve

Right now we're using the value given by -moz-gtk-csd-titlebar-radius, so should be the GTK3 radius.

I tried to fix this the other day but always got artifacts, will try again later when I have more free time.

rafaelmardojai avatar Jun 18 '22 18:06 rafaelmardojai

To be clear, is it still impossible to round bottom corners?

polyjitter avatar Jul 03 '22 02:07 polyjitter

To be clear, is it still impossible to round bottom corners?

image The implementation of the theme is through userchrome.css, basically visual changes are made with CSS and this implies that we cannot modify how the window is drawn on the screen.The most I managed to do was round the corners of the Appcontent, but the window will still be from behind.I've seen some people managing to put rounded corners with Mutter-Rounded, but many report artifacts.

CleoMenezesJr avatar Jul 16 '22 05:07 CleoMenezesJr

I see. Then, would it be possible to get a config option to set whatever is down there that can be rounded, as rounded? That way, those with mutter-rounded don't have to fiddle with the css themselves.

On Sat, Jul 16, 2022, at 1:51 AM, Cleo Menezes Jr. wrote:

To be clear, is it still impossible to round bottom corners?

image https://user-images.githubusercontent.com/54215258/179341775-9d61383c-3617-4a1a-b680-1c9838104771.png The implementation of the theme is through userchrome.css, basically visual changes are made with CSS and this implies that we cannot modify how the window is drawn on the screen.The most I managed to do was round the corners of the Appcontent, but the window will still be from behind.I've seen some people managing to put rounded corners with Mutter-Rounded, but many report artifacts.

— Reply to this email directly, view it on GitHub https://github.com/rafaelmardojai/firefox-gnome-theme/issues/405#issuecomment-1186096213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKJYQFTOYTAFI5QJFEXN63VUJEWNANCNFSM5ZENI54Q. You are receiving this because you commented.Message ID: @.***>

polyjitter avatar Jul 16 '22 07:07 polyjitter

Hello!

The best solution I've seen is to use this gnome shell extension: https://github.com/yilozt/rounded-window-corners

IIRC It's developed by the same person behind Mutter-Rounded and doesn't seem to have artifacting issues (from my experience).

ceiphr avatar Oct 22 '22 11:10 ceiphr

I've been using the rounded window corners extension linked above and the border rounding, shadows, window chrome of firefox in general is now indistinguishable from GNOME Web and other libadwaita apps. Much better approach than using CSS.

aadilayub avatar Apr 17 '23 08:04 aadilayub

Setting GTK theme to adw-gtk3 should be enough.

image

Rounded bottom borders can be enabled with widget.gtk.rounded-bottom-corners.enabled, be aware that this option has some minor bugs.

EDIT: When there is any blurred objects on a website, rounded corners will disappear

Kimiblock avatar Nov 14 '23 17:11 Kimiblock