firefox-gnome-theme icon indicating copy to clipboard operation
firefox-gnome-theme copied to clipboard

Match theme with GTK4/libadwaita

Open SeaDve opened this issue 3 years ago • 9 comments

GTK4 buttons are noticeably flatter, and popovers has different styles

SeaDve avatar May 26 '21 06:05 SeaDve

This should be made behind a preference since the GTK3 -> GTK4 apps migration will be slow.

Even GNOME Web will be GTK3 for a while.

rafaelmardojai avatar May 27 '21 16:05 rafaelmardojai

would this be the proper issue/place to report issues for the libadwaita branch?

iam-cult avatar Jan 17 '22 17:01 iam-cult

would this be the proper issue/place to report issues for the libadwaita branch?

Yep, it's fine.

Just take in account that it's a WIP branch that has been progressed by contributors. I will finish and merge it to master when using GNOME 42, so when Fedora 36 gets released around April.

rafaelmardojai avatar Jan 17 '22 18:01 rafaelmardojai

the libadwaita branch looks pretty good so far to me here on gnomeos nightly, the only things I've noticed is the corner radius of the window, strange contrast in the searchbar popup, and the lack of a dark variant.

iam-cult avatar Jan 17 '22 18:01 iam-cult

additionally, the private window is still old adwaita

iam-cult avatar Jan 17 '22 18:01 iam-cult

I noticed that if you apply the firefox-gnome-theme libadwaita theme, then when you start firefox in the window manager (not only in firefox), the minimize and maximize buttons are activated, and you can no longer disable them either through tweak tools or through dconf, only restarting the PC, after turning on the buttons, there is no until you start firefox, is it just me? изображение

P.S. The design theme turned out to be nothing to do with it, the reason was something else But for that there you can see that the indent between the hamburger button and minimize the window needs to increase the distance )))

DeadMozay avatar Jan 21 '22 10:01 DeadMozay

Hi Everyone! First a big thank you to the developer for making such an awesome theme. I just installed v100 and Firefox remains with the normal "GTK3 theme" nothing like the screenshots posted on the main github page. Do we need to change a pref somewhere to get the libadwaita version? or maybe download the theme in the Beta branch? I saw the screenshots and thought it was already in the main branch but maybe I'm wrong. Thank you so much for any help you can provide!

duartec3000 avatar May 24 '22 15:05 duartec3000

@duartec3000 v100 version is the last one with GTK3 style, the GTK4/libadwaita style is in the master branch.

But you should know that the curled script will install the last stable release, so v100 right now. Maybe we should add a flag to install master version.

rafaelmardojai avatar May 24 '22 17:05 rafaelmardojai

@rafaelmardojai thank you so much for the quick reply, I have installed manually from master everything is working great so far. Many thanks for the time you invested in this project, it's looking very good!

duartec3000 avatar May 24 '22 19:05 duartec3000