[Bug] Previously Wishlisted filter not working

[Eiion]

Description As the title says, the filter doesn't seem to work. When applied (true) previously wishlisted games aren't displayed, instead every won giveaway gets filtered away.

Steps to Reproduce

1. Go to "Won"
2. Activate filter
3. See error

Expected Behavior Priviously wishlisted giveaways get displayed when the filter is applied with 'true'.

Console Errors I assume this is unrelated but I'm having this one 3 times:

    at Ro.cfh_saveReply (esgst.js:88)
    at Ro.cfh_setReply (esgst.js:88)
    at Object.setPopout (esgst.js:88)
    at Ro.init (esgst.js:88)
    at async R.loadFeatures (esgst.js:1)
    at async t (esgst.js:88)

System (please complete the following information):

• ESGST Version: Extension v8.8.5,
• Browser + Version: Chrome Version 86.0.4240.198 (Official Build) (64-Bit)

[rafaelgomesxyz]

I really cannot reproduce this. I tried it several times following these steps:

1. Added a game to my wishlist
2. Synced owned/wishlisted/ignored games on ESGST
3. Removed the game from my wishlist
4. Synced owned/wishlisted/ignored games on ESGST
5. Game appears fine when filtering by previously wishlisted

So I added a log to the next version that could help identify the problem. Let me know what the log says when you sync after removing a game from your wishlist, when the version is released.

[Eiion]

I was using it on the won page where I originally intended it to use when making the suggestion. Maybe there's an error of thought.

Edit: I actually mention that above (I'm on o oboe and didn't bother scrolling up before). Anyways, I don't see how your way to test it would work in that case since you cannot wishlist already won games anymore. Maybe wishlisting a game that you've just won, right bevor activating its key, would work for a test.

[rafaelgomesxyz]

It doesn't matter where you're using it. If you had a game on your wishlist, and you synced, and the game is no longer on your wishlist, it should be marked as previously wishlisted.

I don't understand the confusion here. Picture this:

1. You had a game on your wishlist
2. You had synced your data, so ESGST knows that the game was on your wishlist
3. You won the game and activated it, so it was removed from your wishlist
4. You synced your data again, so now ESGST knows that the game is no longer on your wishlist
5. The game should now be marked as previously wishlisted

Isn't that how it should work?

[Eiion]

That is how it should work, no matter on what page. The difference though is that you have tried it with games that you do not own while I tried it with games that I now do own, as the filter was originally intented. And maybe there's the issue, that - for whatever reason - it doesn't work with games that you now own. Next time you win something, just give it a try with that game instead to see if it doesn't work for you as well (as it doesn't for me).

[rafaelgomesxyz]

Ah, gotcha.

Next time you win something

Probably not happening anytime soon, as I haven't entered giveaways in months. xD But I'll try to see if I can simulate it with a game I own.

[Eiion]

I again won something which I had on my wishlist that doesn't show up when using the previously wishlisted filter on the won page.