Whitelist/Blacklist Checker: fix bug that does not fetch all pages in some locations

[cassolv]

In at least some locations, the WL/BL checker is not fetching all pages when being fed a multi-page user list. For example, if I run it on my whitelist, only exactly fifty people are checked, every time. I haven't checked again to be 100% sure, but I am 99% sure it's the first two pages. The two pages that are checked are the same regardless of the number of the page I run the check on (if I run it on page 1 or on page 4, it's the same result, only pages 1-2 are checked).

ESGST 8.3.17 on Pale Moon 28.6.1. I found no console errors that look particularly related, but I do have a crapload of mostly meaningless stuff on all the consoles I have here, so I might have just missed it.

[rafaelgomesxyz]

Does it show the status correctly before it starts checking like below?

Retrieving users (page x of y)...

Does it go through all of the pages in that status?

[cassolv]

I'll check again tomorrow, but, unless I'm very badly mistaken, it shows first "page 1 of 2" and then "page 2 of 2", even though there are more.

[cassolv]

I ran it on the whitelist page (25 users per page) and I unless my eyes greatly deceive me I actually saw it say "page 1 of 1" (rather than 1 of 2 as I had said) very briefly until 50 users were loaded. Then it checked the users from pages 1 and 2. But maybe it actually said 1 of 2 and it was just so fast that my brain got confused.

I tried again on page 3 just to see what would happen, and I think I could see "page 1 of 2" very briefly and "page 2 of 2" even more briefly (for maybe a tenth of a second). It then started to check out the same users (I cancelled the second attempt). But I'm no longer completely sure that I didn't see "page 1 of 1", either.

In any event, I can be sure of three things: x doesn't go beyond 2, y is not the correct number, and I'm seeing the users from the first two pages rather than from all no matter the number of the page on which I run the feature.

[rafaelgomesxyz]

Ok, thanks for the info, will try to locate the bug.

[rafaelgomesxyz]

Can you check if "Check only pages from" is enabled?

[cassolv]

Where exactly? I looked around and couldn't find anything with that name.

[rafaelgomesxyz]

Uncheck "Check all pages" and this option should appear, it's in the checker popup.

[cassolv]

Now, that's interesting. Quite interesting. I see no such option, either. Those are the options I'm seeing:

Only check blacklist.
Return whitelists.
Return blacklists.
Only check users who have not whitelisted /blacklisted you.
Skip users after [X] pages.
Clear caches.

I keep options 4 and 5 marked to make it faster, and X is set to 10.

If I run it on pages with multi-manager, I also get the Only check selected. option.

[cassolv]

BTW, 8.5.0 does not load for me, but I'm on PM 28.6.1 and 28.7.0 comes with changes to the JS parser, so I'm going to wait until I update the browser before actually complaining. But that also means I can't test the new version for changes, which is why I'm mentioning this.

[rafaelgomesxyz]

It's not working for everyone, I'm trying to find out what went wrong.

[rafaelgomesxyz]

Wow, this is more than a year old. Sorry about that. I assume this is still an issue?

[cassolv]

Oops, I missed your message there, sorry.

I checked just now and it's still an issue. Going to my own whitelist and trying it only runs the feature on the first 25 users, and it explicitly says "page 1 of 1".

[rafaelgomesxyz]

Alright, I'll add some logs to the next version. Let me know what they say when it's released.

[rafaelgomesxyz]

Did you get around to checking the logs?