webpack-auto-inject-version icon indicating copy to clipboard operation
webpack-auto-inject-version copied to clipboard

Bug in disabled `InjectAsComment`

Open bespoyasov opened this issue 6 years ago • 1 comments

Hi! I think I found a bug in InjectAsComment.

With this config:

// ...
new WebpackAutoInject({
  componentsOptions: {
    InjectByTag: { 
      dateFormat: 'h:MM:ss' 
    }
  }
})

plugin works correctly and replaces [AIV]{date}[/AIV] in html-file with date string.

But when I try to disable comment injecting:

// ...
new WebpackAutoInject({
  components: {
    InjectAsComment: false,
  },
  componentsOptions: {
    InjectByTag: { 
      dateFormat: 'h:MM:ss' 
    }
  }
})

plugin won't replace [AIV]{date}[/AIV] width date anymore.

I'm not sure if this is a bug, but I supposed those features worked independently.

P.S. Thanks for the plugin! :–)

bespoyasov avatar Mar 09 '18 23:03 bespoyasov

I have this problem too. issue is 2 years old, so I guess the project is abandoned

VividWombat avatar Mar 01 '20 10:03 VividWombat