Radosław Mejer

Results 38 comments of Radosław Mejer

Thanks for the code. I'll try to check it tomorrow.

@lokendrajoshi54 I did some testing with the examples you gave. `SoftDeletes` trait works with pivot model when fetching related records. Here's the test case I used: https://github.com/radmen/adonis-lucid-soft-deletes/blob/5835dd4311dd174d10873afa3fca8786440025b0/test/softDeletes.spec.js#L314-L336 There's a problem...

> Same thing is applicable for withTrashed() method. In which context does this apply? `whereHas()`? > Is there any way I can help in this? First thing we need to...

I was able to reproduce the problem on clean Adonis application. Its been reported: https://github.com/adonisjs/adonis-lucid/issues/429

@lokendrajoshi54 I'm aware of that. In fact it seems that this is something that is not possible in Lucid. I've [asked](https://github.com/adonisjs/adonis-lucid/issues/429#issuecomment-471912431) about it, yet without any answer.

@arlenmendes thanks for feedback. This is true, however, the same applies to the [original delete method](https://github.com/adonisjs/adonis-lucid/blob/6cd666df9534a981f4bd99ac0812a44d1685728a/src/Lucid/Model/index.js#L808-L832). I could probably add support for transactions (by passing `trx` parameter), yet this is...

There's even an open ticket for that - https://github.com/adonisjs/adonis-lucid/issues/447

@arlenmendes this should be fairly easy to fix. When I'll find the time I will push a fix to upstream and then re-merge it to this package.

+1 for that.