shadcn-vue icon indicating copy to clipboard operation
shadcn-vue copied to clipboard

fix: `new-york` component type error.

Open linbingquan opened this issue 1 year ago โ€ข 2 comments

๐Ÿ”— Linked issue

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [x] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Fix error TS6133: '*' is declared but its value is never read.

src/components/ui/chart-area/AreaChart.vue:86:16 - error TS6133: 'd' is declared but its value is never read.

86           :x="(d: Data, i: number) => i"
                  ~

src/components/ui/chart-area/AreaChart.vue:101:16 - error TS6133: 'd' is declared but its value is never read.

101           :x="(d: Data, i: number) => i"
                   ~

src/components/ui/chart-bar/BarChart.vue:74:14 - error TS6133: 'd' is declared but its value is never read.

74         :x="(d: Data, i: number) => i"
                ~

src/components/ui/chart-bar/BarChart.vue:81:23 - error TS6133: 'd' is declared but its value is never read.

81             opacity: (d: Data, i:number) => {
                         ~

src/components/ui/chart-donut/DonutChart.vue:82:30 - error TS6133: 'ev' is declared but its value is never read.

82             click: (d: Data, ev: PointerEvent, i: number, elements: HTMLElement[]) => {
                                ~~

src/components/ui/chart-line/LineChart.vue:67:16 - error TS6133: 'd' is declared but its value is never read.

67           :x="(d: Data, i: number) => i"
                  ~

src/components/ui/chart/ChartCrosshair.vue:36:16 - error TS6133: 'd' is declared but its value is never read.

36 function color(d: unknown, i: number) {

๐Ÿ“ธ Screenshots (if appropriate)

๐Ÿ“ Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

linbingquan avatar Sep 24 '24 14:09 linbingquan

There are import code was sorted by git-hooks. I don't want to change. If this PR has any problem, please tell me.

linbingquan avatar Sep 24 '24 14:09 linbingquan

Hi thanks for the PR

Those unused params or imports might be later used on refactoring charts, so let's keep it

sadeghbarati avatar Sep 25 '24 04:09 sadeghbarati