shadcn-vue icon indicating copy to clipboard operation
shadcn-vue copied to clipboard

feat(components): add carousel dot buttons

Open quankhuc opened this issue 1 year ago • 4 comments
trafficstars

Add dot buttons to carousel component based on the availablity of dot buttons in embla carousel vue.

quankhuc avatar May 03 '24 16:05 quankhuc

IMO, this is too much, which can be added by the user

also, not working well with orientation. Carousel Dots should respect the orientation

sadeghbarati avatar May 05 '24 09:05 sadeghbarati

I think we can have this addition be part of the component. As it doesn't required much refactoring, and the DotButtons make sense. As @sadeghbarati said let's make sure that it is respectively the orientation ya 😁

zernonia avatar May 06 '24 07:05 zernonia

Thank for your suggestions! I will fix it so that it can look good with orientation

quankhuc avatar May 07 '24 03:05 quankhuc

I have fixed the code to make it work with orientation. Please let me know what you think!

quankhuc avatar Jun 04 '24 21:06 quankhuc