shadcn-vue icon indicating copy to clipboard operation
shadcn-vue copied to clipboard

[Feature]: Add better syntax highlighting to ComponentPreview

Open Saeid-Za opened this issue 1 year ago • 2 comments
trafficstars

Describe the feature

There is currently a black & white theme for code highlighting in Documentation, I'd suggest changing this to a more vibrent theme, like the current theme used in radix-vue documents.

Additional information

  • [X] I intend to submit a PR for this feature.
  • [ ] I have already implemented and/or tested this feature.

Saeid-Za avatar Mar 03 '24 17:03 Saeid-Za

I agree with that but I thought it would be better to be like main shadcn-ui that's why I didn't use shiki themes

sadeghbarati avatar Mar 03 '24 17:03 sadeghbarati

I understand your point, but with the Vue ecosystem, we have the ability to incorporate features that are not available in shadcn-ui (the React version). We are not limited to only support what shadcn-ui supports.

I have cloned and modified shadcn-vue to suit my own needs, and some of the changes I've made could benefit the end-users that are not currently implemented in shadcn-ui. I am working on creating some feature improvement requests based on my experiments.

Regarding this particular feature request, I may have a bias towards certain styles. If you believe that the current styling is better, feel free to close this issue as resolved. ❤️

Saeid-Za avatar Mar 03 '24 20:03 Saeid-Za