shadcn-vue icon indicating copy to clipboard operation
shadcn-vue copied to clipboard

[Bug]: Dialog programatic close slot not working

Open gespinha opened this issue 4 weeks ago • 1 comments

Reproduction

https://stackblitz.com/edit/znxobv2n?file=src%2FApp.vue

Describe the bug

Dialog doesn't close when using the close v-slot on the Dialog root component.

It works in RekaUI, but not in the shadcn-vue wrapper.

System Info

System:
    OS: macOS 15.7.1
    CPU: (12) arm64 Apple M3 Pro
    Memory: 107.48 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.17.0 - /usr/local/bin/node
    npm: 10.9.2 - /usr/local/bin/npm
    pnpm: 10.14.0 - /usr/local/bin/pnpm
  Browsers:
    Edge: 141.0.3537.99
    Safari: 18.6
  npmPackages:
    @vueuse/core: ^13.9.0 => 13.9.0 
    reka-ui: ^2.6.0 => 2.6.0 
    shadcn-vue: ^2.3.1 => 2.3.1 
    vue: ^3.5.13 => 3.5.22

Contributes

  • [ ] I am willing to submit a PR to fix this issue
  • [ ] I am willing to submit a PR with failing tests

gespinha avatar Nov 02 '25 02:11 gespinha

Right 👍

Will try to add fallthrough slotProps for all the shadcn-vue components if it has slotProps

sadeghbarati avatar Nov 02 '25 15:11 sadeghbarati

all v4 registry components are passed the slotProps

sadeghbarati avatar Nov 16 '25 04:11 sadeghbarati