primitives icon indicating copy to clipboard operation
primitives copied to clipboard

feat: make `data-state` more explicit

Open chaejunlee opened this issue 1 year ago • 1 comments

Description

  • fixes https://github.com/radix-ui/primitives/issues/602
  • ref https://github.com/radix-ui/primitives/discussions/560#discussioncomment-3115606

Reading the comments from the discussion, I made the date-state more explicit by adding the name of the radix component. This feature will help the namespace of data-state be more clean.

I think leaving the data-state as a legacy and adding data-[component]-state will be good for now. For next major update, we can drop the support for the data-state.

If the maintainers agree on this approach, I can update all the storybook examples to new data-state representation as well. Please, any feedback is appreciated!!!

chaejunlee avatar Feb 21 '24 05:02 chaejunlee

This looks like the best solution for the problem. Keeping the simple DX from data-state plus olving the problem.

Obiwarn avatar Jun 19 '24 08:06 Obiwarn