[Select] Closes on resize when the window size has changed
Closes #2634
Hey @georgekaran, sorry it took awhile to get to this! Two quick changes I'll request:
- Could you resolve the merge conflicts? I think it's probably just a filename issue, but if it's more involved let me know and I can help
- Can we not attach the event listener when the popover is already closed?
⚠️ No Changeset found
Latest commit: 8d4457b8ce5533e0f6378cabc7117b5f81bdd681
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Thanks for the review @chaance!
You were right, it was just a filename issue. Also, great catch! I've made that change as well.
Let me know if there's anything else I could do.