primitives icon indicating copy to clipboard operation
primitives copied to clipboard

Correctly concatenate aria-describedby in a slot

Open wbolduc opened this issue 2 years ago • 2 comments

Description

aria-describedby is technically a list of ids and should be concatenated kind of like className.

This pr fixes my own issue where this is described

Tests are included

wbolduc avatar Dec 19 '23 02:12 wbolduc

Is there something wrong with my pr?

wbolduc avatar May 13 '24 00:05 wbolduc

I'm not entirely sure we want to do this. Yes, aria-describedby can be more than one string but I think the component should be explicit about which element(s) are used as descriptions. With this solution there's no way for a consumer to explicitly override what Radix does internally, which may be valid in some cases.

chaance avatar Sep 27 '24 00:09 chaance