primitives
primitives copied to clipboard
radix-ui
[Select] Fix dispatch touch events when closing
Description
I'm using a similar approach as used in Menu to select an item which uses the onClick event. I couldn't test if it works in safari because I don't have access to one, so if you guys can test it there, thanks :pray:
Fixes #1658
Can this please be looked after? This is pretty important for our project, Thanks! :)
@benoitgrelard @andy-hook Just wanted to ping you both since you're code owners and you're review is required to merge.
This PR fixes a critical issue first reported in September of 2022 (#1658). It's already been approved by @bryanltobing and @eduardofioritokabum. I know you all have a ton on your plate, but could we please get some eyes on this and get it merged? It's a critical app-breaking bug for our team (and it looks like many others).
Many many thanks! My team and I LOVE Radix. It's been a game-changer for us. 🙏🎉
CC @joaom00
@andy-hook @benoitgrelard This PR seems to be a fix for an issue many people has encountered. Could we get it merged?
Chiming in just to reiterate the importance of this in the hopes of someone taking a look at it. Any news about this would be appreciated 🙏
@benoitgrelard @andy-hook this one would be greatly appreciated if you can find the time
Hey @joaom00 I oppened Select.tsx on my project and it looks very different to yours.. I opened the one in @/components/ui/. where exactly do I find the source you modified to be able to apply this fix?
Hi! I don't think that comments only asking for it to be merged is helpful... remember, we use this for free!
However I do think all community and users of Radix will greatly appreciate a clear statement of this library maintenance status. Seems like there's a ton of PRs and issues not being addressed... (and new components!). Also, if it's not actively maintained, it helps future folk on making a decision of which headless ui library to go for.
How can we help? @benoitgrelard @andy-hook
