radish icon indicating copy to clipboard operation
radish copied to clipboard

WIP: Feature/support multiple tags on single line

Open fliiiix opened this issue 2 years ago • 5 comments

  • Needs CI branch fixed & merged
  • Needs tests
  • Update docs

fliiiix avatar Jul 07 '21 19:07 fliiiix

Codecov Report

Base: 86.03% // Head: 86.33% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (ff246b8) compared to base (cb8b86d). Patch has no changes to coverable lines.

:exclamation: Current head ff246b8 differs from pull request most recent head e1ae80a. Consider uploading reports for the commit e1ae80a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   86.03%   86.33%   +0.30%     
==========================================
  Files          39       39              
  Lines        2342     2401      +59     
==========================================
+ Hits         2015     2073      +58     
- Misses        327      328       +1     
Flag Coverage Δ
unittests 86.33% <0.00%> (+0.30%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
radish/compat.py 85.71% <0.00%> (-14.29%) :arrow_down:
radish/core.py 100.00% <0.00%> (ø)
radish/feature.py 100.00% <0.00%> (ø)
radish/matcher.py 100.00% <0.00%> (ø)
radish/scenario.py 100.00% <0.00%> (ø)
radish/background.py 100.00% <0.00%> (ø)
radish/scenarioloop.py 100.00% <0.00%> (ø)
radish/stepregistry.py 100.00% <0.00%> (ø)
radish/examplescenario.py 100.00% <0.00%> (ø)
radish/scenariooutline.py 100.00% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 07 '21 19:07 codecov[bot]

Hi @fliiiix, are you still working on the PR? Please let me know if you are not, I would like to try implementing the tests for the feature. Thanks.

vchrombie avatar Mar 02 '22 11:03 vchrombie

@vchrombie the current master branch is the start of an entirely new parser based on an EBNF parser using lark.

AFAIK, currently it wouldn't support multiple tags on a single line, so you'd have to start from scratch there.

timofurrer avatar Mar 02 '22 11:03 timofurrer

@timofurrer thanks for the clarification. I'll probably try it. :+1:

vchrombie avatar Mar 02 '22 11:03 vchrombie

@vchrombie I think i kinda forgot about this so feel free to take this as a start

from my comments i would guess something worked with this branch but not to sure tbh ^^

fliiiix avatar Mar 02 '22 16:03 fliiiix

replaced by https://github.com/radish-bdd/radish/pull/451

fliiiix avatar Feb 26 '23 17:02 fliiiix