Invalid "no connection to peer" when tracking projects

[viraptor]

I've got a seed which has problems tracking new projects. Specifically I see behaviour like this:

Feb 22 00:11:56 radicle-seed radicle-seed-node[2339]: Feb 22 00:11:56.844  INFO Protocol::run{local.id=hyy4ebh8amk3ypyawgpjnfpbgkxqwdo5n1iif5s17yghwmewrf4d8a local.addr=0.0.0.0:12345}: librad::net::protocol: Establishing connection remote.id=hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a
Feb 22 00:11:57 radicle-seed radicle-seed-node[2339]: Feb 22 00:11:57.135  INFO Protocol::run{local.id=hyy4ebh8amk3ypyawgpjnfpbgkxqwdo5n1iif5s17yghwmewrf4d8a local.addr=0.0.0.0:12345}: librad::net::protocol: New outgoing connection remote.id=hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a
Feb 22 03:16:52 radicle-seed radicle-seed-node[2339]: Feb 22 03:16:52.270  WARN Storage::fetch{local.id=hyy4ebh8amk3ypyawgpjnfpbgkxqwdo5n1iif5s17yghwmewrf4d8a url=rad+git://hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a/hwd1yregw17ay46kei7erkfbkp7ojr6d7n4zk9mcmksnu35eonqon7oyayh/}: librad::net::protocol: Error opening git stream: no connection to hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a
Feb 22 03:16:52 radicle-seed radicle-seed-node[2339]: Feb 22 03:16:52.271  INFO radicle_seed: Error tracking project rad:git:hwd1yregw17ay46kei7erkfbkp7ojr6d7n4zk9mcmksnu35eonqon7oyayh from peer hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a: No connection to hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a
Feb 22 03:16:52 radicle-seed radicle-seed-node[2339]: Feb 22 03:16:52.272  INFO radicle_seed: Discovered new URN rad:git:hwd1yregw17ay46kei7erkfbkp7ojr6d7n4zk9mcmksnu35eonqon7oyayh from peer hyy3gd46q98gmd4j5getmxwfxqrcddkc1jdajbqq6gcei98nbi5h1a

(these are all the lines in the log containing that peer)

In other words:

• I've got the peer in the connected list
• get an announcement about a project (from that peer)
• git stream fails to open, because "No connection to {same peer}"

Is this likely just a maint issue, or can I give you some more information to investigate?

[kim]

I think this is due to some racy code which would incorrectly assume that connections can naively be keyed by peer id. This should have been fixed, but perhaps we can keep this open until after the next release, just to confirm.

[xla]

@viraptor If you are feeling adventurous you can hop on the latest stack by running branches of Upstream and the Seed:

https://github.com/radicle-dev/radicle-upstream/tree/xla/1236-thank-you-next https://github.com/radicle-dev/radicle-bins/tree/seed-net-next

This will set you up with the changes for the upcoming Upstream 0.2.0 and the accompanying seed binary.